Feature #7
Open
Feature #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple append css invert to html dom so if using tag <a> it will refresh otherwise <route-link>
viko16
reviewed
Mar 30, 2020
components/Home.vue
Outdated
| <div | ||
| v-if="filteredList.length === 0" | ||
| class="empty-list" | ||
| > | ||
| Ooops! Nothing here..🙈 | ||
| 落了片白茫茫大地真干净。 |
There was a problem hiding this comment.
建议不要直接 hardcode 中文，可以考虑支持下多语言，或者是直接用 $lang 判断
example/.vuepress/config.js
Outdated
| }, | ||
| plugins: [ | ||
| '@vuepress/search', |
There was a problem hiding this comment.
如果要加上 Search 插件，不能只给 example 加，要放到顶级的 index.js 里
参考 https://vuepress.vuejs.org/theme/writing-a-theme.html#apply-plugins
|
非常感谢你提交的一些新功能，我本地用过之后觉得很棒。 但在合并之前先提一些建议：
欢迎继续讨论。 |
|
感谢回复。 翻页或许是见仁见智的，首页列表过长(>50)会影响观感，作为配置项如何，这是否违背了 simple 的初衷？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for making this theme.